[PATCH] Rework handling of basename variants

Corinna Vinschen vinschen@redhat.com
Wed Jul 8 15:05:00 GMT 2015

On Jul  6 13:10, Yaakov Selkowitz wrote:
> As a commonly-included header, the #define basename in <string.h> can
> affect code which uses "basename" for its own purposes (e.g. struct
> members or C++ namespaced functions).  When such cases occur and some
> code includes <string.h> and some not, then errors result.  OTOH,
> <libgen.h> is rarely used, and that's where the renaming occurs in
> glibc, so code using <libgen.h> should already be safe.
> ---
>  newlib/libc/include/libgen.h | 5 +++--
>  newlib/libc/include/string.h | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)

Apart from the missing ChangeLog entry, the patch is ok.


Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20150708/bd4c05e1/attachment.sig>

More information about the Newlib mailing list