[PATCH] Prevent use of uninitialized file lock
Sebastian Huber
sebastian.huber@embedded-brains.de
Wed Jul 1 13:33:00 GMT 2015
On 01/07/15 14:52, Sebastian Huber wrote:
>>
>> Btw., don't we have the same problem in libc/stdio/gets.c as well?
>
> Probably yes. It seems a _REENT_SMALL_CHECK_INIT (ptr) is missing as
> well? I try to add this to the second version.
This _gets_r() looks quite dubious:
char *
_DEFUN(_gets_r, (ptr, buf),
struct _reent *ptr _AND
char *buf)
{
register int c;
register char *s = buf;
_newlib_flockfile_start (stdin);
while ((c = __sgetc_r (ptr, stdin)) != '\n')
if (c == EOF)
if (s == buf)
{
_newlib_flockfile_exit (stdin);
return NULL;
}
else
break;
else
*s++ = c;
*s = 0;
_newlib_flockfile_end (stdin);
return buf;
}
We have:
#define stdin (_REENT->_stdin)
so we don't use the ptr->_stdin? Is this intentional?
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
More information about the Newlib
mailing list