Patch: Change from configure time to compile time probe for intptr_t, definition.

Joel Sherrill
Mon Mar 23 14:20:00 GMT 2015

It is pushed now. Hopefully all is OK.

I don't know if newlib.hin needs to be regenerated or not.
I would have thought it would but neither autoconf nor
autoheader touched it. I certainly could have forgotten
the magic incantation though.



On 03/23/2015 08:54 AM, Corinna Vinschen wrote:
> On Mar 23 08:12, Joel Sherrill wrote:
>> On 03/23/2015 05:17 AM, Corinna Vinschen wrote:
>>> Hi Joel,
>>> The patch looks good... almost.  No worries, it's my fault:
>> Great. This patch seems to take care of the issue pretty
>> reliably.
>> I spent a lot of time building over the past few days and this
>> patch really helped reduce the warnings in the RTEMS tests.
>> We are almost to 0 warnings across the targets except m32c
>> which ICEs so much building RTEMS with "make -k" that I
>> can't tell much of anything.
>> [...]
>>> It occured to me that this is not without danger.  Assuming you're using
>>> a compiler ignoring the push_macro/pop_macro pragmas, then the above
>>> macro definitions of signed, int and long will prevail from this point
>>> on.  Therefore, to be really sure, another set of #undef's should be
>>> inserted here:
>>>    #undef signed
>>>    #undef int
>>>    #undef long
>> OK. I will update the patch.
>> I also noticed that newlib.hin didn't get updated. What's the
>> magic for that?
>>>> +#pragma pop_macro("signed")
>>>> +#pragma pop_macro("int")
>>>> +#pragma pop_macro("long")
>>>>   #endif /* __SYS_CONFIG_H__ */
>>> With that change, ok to push.
>> My first newlib git push. :)
> I was nervous like hell :)
>> Is there any guidance for the commit message?  I think binutils/gdb
>> has been doing something like this:
>> ================
>> summary line/title
>> ChangeLog entry
>> ================
>> Is that OK?
> That's what I'm doing as well, except for very tiny stuff for which
> I just use the summary line.  It certainly won't hurt to follow
> binutils/gdb.
> Thanks,
> Corinna

-- Joel Sherrill, Ph.D. Director of Research&  Development On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985

More information about the Newlib mailing list