[PATCH,MIPS 3/3] Setting of status register based on .MIPS.abiflags

Matthew Fortune Matthew.Fortune@imgtec.com
Wed Nov 26 22:50:00 GMT 2014


> On Tue, 2014-11-18 at 12:26 +0000, Matthew Fortune wrote:
> 
> > +	/* Read MIPS_abiflags structure and set status/config registers
> > +	   accordingly.  */
> > +	.weak	__MIPS_abiflags_start
> > +	.weak	__MIPS_abiflags_end
> > +	LA	(t0,__MIPS_abiflags_start)
> > +	LA	(t1,__MIPS_abiflags_end)
> > +	addiu	t1,t1,-24
> > +	move	v0,zero			/* Mask for C0_SR.  */
> > +	bne	t0,t1,1f
> 
> I would add a bit more to the comment here to explicitly say that we are
> checking to see if the abiflags structure is defined and jumping to '1f'
> if it is not.
> 
> Other then that the patch looked OK to me.

OK, I agree the test is a bit odd. I'll send an updated patch in the next
day or so.

Thanks,
Matthew



More information about the Newlib mailing list