[PATCH] libc/time/gmtime_r.c, libc/time/lcltime_r.c,, libc/time/local.h, libc/time/mktm_r.c: move localtime related functionality, from _mktm_r() to new _mklocaltm_r() to break dependency of gmtime() on, timezones

Jeff Johnston jjohnstn@redhat.com
Thu Sep 11 21:57:00 GMT 2014


Patch checked in.  I modified the slashes used in your ChangeLog entry to be non-Windows :)

-- Jeff J.

----- Original Message -----
From: "Freddie Chopin" <freddie_chopin@op.pl>
To: newlib@sourceware.org
Sent: Thursday, September 11, 2014 4:18:20 PM
Subject: Re: [PATCH] libc/time/gmtime_r.c, libc/time/lcltime_r.c,, libc/time/local.h, libc/time/mktm_r.c: move localtime related functionality, from _mktm_r() to new _mklocaltm_r() to break dependency of gmtime() on, timezones

W dniu 2014-09-11 21:51, Jeff Johnston pisze:
> Hi Freddie,
>
> Corinna who was looking at this previously is on vacation so I am reviewing it.

Good to know, thanks for your review!

> The only comments I have are:
>
> 1. month_lengths needs to be renamed to be __month_lengths because it is now externalized.
> 2. you might as well be consistent with other files in LIB_SOURCES list of Makefile.am with regards to tabs vs spaces.

Both issues fixed. Updated patch and updated changelog attached.

Regards,
FCh



More information about the Newlib mailing list