broken attributes

Eric Blake eblake@redhat.com
Thu Jul 31 14:13:00 GMT 2014


On 07/31/2014 06:45 AM, Eric Blake wrote:
> The following grep shows a number of places where newlib is improperly
> using __attribute__ markups without decorating the attribute with __ to
> ensure that there are no collisions with user-defined macros.
> 
> $ find -name '*.h' |xargs grep -i 'attribute.*(([a-z]'
> 

> 
> I'm preparing an obvious patch of decorating all these offenders with __
> 

attached:

2014-07-31  Eric Blake  <eblake@redhat.com>

	* libc/machine/spu/spu_timer_internal.h: Decorate attribute names
	with __, for namespace safety.
	* libc/machine/xscale/machine/profile.h: Likewise.
	* libc/include/stdlib.h: Likewise.
	* libc/include/_ansi.h: Likewise.
	* libc/include/sys/unistd.h: Likewise.
	* libc/sys/linux/linuxthreads/libc-symbols.h: Likewise.
	* libc/sys/linux/linuxthreads/internals.h: Likewise.
	* libc/sys/linux/machine/i386/weakalias.h: Likewise.
	* libc/sys/linux/machine/i386/dl-procinfo.h: Likewise.
	* libc/sys/linux/machine/i386/dl-machine.h: Likewise.
	* libc/sys/linux/libc-symbols.h: Likewise.
	* libc/sys/linux/iconv/gconv_charset.h: Likewise.
	* libc/sys/linux/include/resolv.h: Likewise.
	* libc/sys/linux/sys/unistd.h: Likewise.
	* libc/sys/linux/dl/atomicity.h: Likewise.
	* libc/sys/linux/dl/dynamic-link.h: Likewise.
	* libc/sys/linux/dl/ldsodefs.h: Likewise.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: decorate.patch
Type: text/x-patch
Size: 23455 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20140731/852b044d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/newlib/attachments/20140731/852b044d/attachment.sig>


More information about the Newlib mailing list