[PATCH Newlib]Dont inline std when optimizing for size

bin.cheng bin.cheng@arm.com
Mon Jun 9 10:48:00 GMT 2014


> -----Original Message-----
> From: newlib-owner@sourceware.org [mailto:newlib-
> owner@sourceware.org] On Behalf Of bin.cheng
> Sent: Thursday, December 12, 2013 5:01 PM
> To: pinskia@gmail.com
> Cc: newlib@sourceware.org
> Subject: RE: [PATCH Newlib]Dont inline std when optimizing for size
> 
> 
> 
> > -----Original Message-----
> > From: pinskia@gmail.com [mailto:pinskia@gmail.com]
> > Sent: Thursday, December 12, 2013 4:15 PM
> > To: Bin Cheng
> > Cc: <newlib@sourceware.org>
> > Subject: Re: [PATCH Newlib]Dont inline std when optimizing for size
> >
> >
> >
> > > On Dec 11, 2013, at 11:47 PM, "bin.cheng" <bin.cheng@arm.com> wrote:
> > >
> > > Hi,
> > > This is just a pickup in newlib.  It specifies _NOINLINE_STATIC for
> > > std since some version (4_8) GCC may inline this function even when
> > > we are compiling for Os.
> > > This is mainly a gcc problem and I have filed
> > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59479 for GCC.
> > >
> > > Meanwhile, I think this is also wanted in Newlib, is it OK?
> >
> > Is it a size win on other targets like MIPS or PowerPC?
> Hi Andrew,
> I just tried it on mips.
> 
> The size info for Os is like:
> 
> With inline:
> __sinit		408
> 
> Without inline:
> __sinit		136
> std.isra.0	136
> 
> I used the default configuration and command line, but I think same story
> stands for other micro controller processors.
> 
> Thanks,
> bin
> 
> >
> > Thanks,
> > Andrew
> >
> >
> > >
> > > Thanks,
> > > bin
> > >
> > > 2013-12-12  Bin Cheng  <bin.cheng@arm.com>
> > >
> > >    * libc/stdio/findfp.c (std): Don't inline when optimizing
> > >    for code size.
> > > <no-inline-std-20131212.txt>
> 
> 
> 
> 


Ping.  It slipped away for a while.
Is it OK?

Thanks,
bin






More information about the Newlib mailing list