RFA: Fix __signbitf() and __signbitd() for 16-bit targets
Corinna Vinschen
vinschen@redhat.com
Wed Dec 18 09:21:00 GMT 2013
On Dec 18 08:52, Nick Clifton wrote:
> Hi Guys,
>
> I ran across a couple of bugs in the implementations of __signbitf()
> and __signbitd() should the target happen to use 16-bit integers:
>
> Firstly the functions pass the "unsigned int" type to the
> GET_FLOAT_WORD and GET_HIGH_WORD macros, but these macros are
> expecting a "__uint32_t" type.
>
> Secondly they assume that the "int" return type is wide enough to hold
> bit 31 of the extracted word.
>
> The patch below fixes both of these problems and results in fixed gcc
> testcase (gcc.dg/pr43419.c) when run on a 16-bit target. (With no
> regressions for 32-bit and 64-bit targets).
>
> OK to apply ?
Yes, thank you.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20131218/0c30cb67/attachment.sig>
More information about the Newlib
mailing list