Patch - Add restrict to wchar.h

Joel Sherrill joel.sherrill@oarcorp.com
Tue Nov 26 15:03:00 GMT 2013


On 11/26/2013 8:06 AM, Corinna Vinschen wrote:
> On Nov 25 09:16, Joel Sherrill wrote:
>> Hi
>> 
>> This should be the last big patch in the add restrict series from
>> Google Code-In students.
>> 
>> This one is large and, although I think it is correct, there is
>> plenty of room for errors. It is a fairly large but monotonous
>> patch.
>> 
>> As best we can tell, newlib has all the wchar.h methods which
>> should have restrict added except wcsxfrm_l().
>> 
>> Let me know if this is OK to commit or needs revision.
> 
> Looks good to me.  Please apply.

Done.

> While we're at the end of the restrict marathon for the POSIX API,
> I'm wondering if we shouldn't apply the same change to the
> reentrant API.
> 
> Otherwise the advantage of the restrict keyword, probably smaller
> and probably faster code, is gone as soon as the the POSIX API
> calls the underlying reentrant functions, and it's not available at
> all for external callers of the reentrant API, isn't it?

If you produce a list of methods, then we would be happy to create
a Google Code-In task for the work. :)

FYI high school students performed over 300 tasks for 10 FOSS projects
in one week.
> Corinna
> 



-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985



More information about the Newlib mailing list