Patch - Add restrict to time.h

Joel Sherrill joel.sherrill@oarcorp.com
Mon Nov 25 16:46:00 GMT 2013


On 11/25/2013 10:41 AM, Howland Craig D (Craig) wrote:
> -----Original Message-----
>> From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]
> On Behalf Of Joel Sherrill
>> Sent: Sunday, November 24, 2013 12:46 PM
>> To: newlib@sourceware.org
>> Subject: Patch - Add restrict to time.h
>>
>> ...
>> Please review this one a little closer than the others.
>>
>> I hope this version is OK to commit but won't be surprised
>> if there are comments. I tried to review it carefully but...
> ...
>>        * libc/time/strftime.c (strftime): Same.
> 
> -	size_t strftime(char *<[s]>, size_t <[maxsize]>,
> -			const char *<[format]>, const struct tm
> *<[timp]>);
> +	size_t strftime(char *restrict<[s]>, size_t <[maxsize]>,
> +			const char *restrict<[format]>,
> +                        const struct tm *restrict<[timp]>);
> 
>  The strftime patch for the man page is missing spaces between restrict
> and the respective pointers, which will make it very hard to read.
> Craig
> 

So change "restrict<[s]>" to "restrict <[s]>"?

If that's the pattern, grep says iconv.c also needs fixing.

If you can confirm that, I will fix those instances.

Thanks.


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985



More information about the Newlib mailing list