[patch] New option --disable-reenterable-atexit

Sebastian Huber sebastian.huber@embedded-brains.de
Wed Oct 16 12:34:00 GMT 2013


On 2013-10-16 12:18, Ye Joey wrote:
> On Wed, Oct 16, 2013 at 4:34 PM, Sebastian Huber
> <sebastian.huber@embedded-brains.de> wrote:
>>> +`--disable-reenterable-atexit'
>>> +     Disable reenterablility of atexit by declare related data structures
>>> +     as global variables. By doing these data structures can be discarded
>>> +     if atexit is not referenced.
>>> +     Enabled by default.
>>
>>
>> I think the naming and the description is a bit misleading.  The atexit()
>> support is not thread specific.  Operations are serialized with the
>> __atexit_lock lock.  In case _REENT_GLOBAL_ATEXIT is undefined, then the
>> data structures for the atexit() support are part of struct _reent, but only
>> used in _GLOBAL_REENT.  Thus the space in the thread specific structures is
>> wasted. See also
>>
>> https://sourceware.org/ml/newlib/2013/msg00355.html
> I named it to mean that atexit isn't in _reent. But _reent isn't a
> good name as option as it is implementation specific data structure
> name.
>
> How about --enable-global-atexit-data, and changes the description accordingly?

Yes, I think this name describes it better.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the Newlib mailing list