question about running autoconf in newlib directory

[Jeff Johnston]

On 07/31/2013 07:57 PM, Steve Ellcey wrote:
> On Tue, 2013-07-30 at 16:16 -0400, Jeff Johnston wrote:
>
>> It is likely that some new check added in the current autoconf is noting
>> we haven't called the base AC_PROG_CC macro and what it subsequently
>> calls.  Although I have seen such warnings, I haven't seen any build
>> issues so I have just left it alone for the time-being.
>>
>> -- Jeff J.
>
> I took a look at where the warning messages were coming from.  It is
> coming out of libtool.m4 (which is at the top level of the source tree
> and shared amongst the various src tree tools.  Other products don't see
> the messages because they are not using autoconf 2.68 or later.  It
> looks like the latest libtool has fixes for these messages but I don't
> know who/how/when a new libtool might be imported into the GCC and
> binutils trees.  If we wanted to cherry-pick the changes needed to make
> the messages go away here is the patch that would do it.
>
> Steve Ellcey
> sellcey@mips.com
>
>


Thanks Steve for researching this.

Maybe we should go back to having our own libtool m4 files in newlib and 
remove the extra -I reference on our aclocal calls that points to the 
top-level src dir.

-- Jeff J.

>
> diff --git a/libtool.m4 b/libtool.m4
> index 8a14e2b..7a37498 100644
> --- a/libtool.m4
> +++ b/libtool.m4
> @@ -1079,7 +1079,7 @@ m4_defun([_LT_DARWIN_LINKER_FEATURES],
>   # to the aix ld manual.
>   m4_defun([_LT_SYS_MODULE_PATH_AIX],
>   [m4_require([_LT_DECL_SED])dnl
> -AC_LINK_IFELSE(AC_LANG_PROGRAM,[
> +AC_LINK_IFELSE([AC_LANG_PROGRAM],[
>   lt_aix_libpath_sed='
>       /Import File Strings/,/^$/ {
>   	/^0/ {
> @@ -4926,7 +4926,16 @@ _LT_EOF
>   	# implicitly export all symbols.
>           save_LDFLAGS="$LDFLAGS"
>           LDFLAGS="$LDFLAGS -shared ${wl}-exported_symbol ${wl}foo ${wl}-update_registry ${wl}/dev/null"
> -        AC_LINK_IFELSE(int foo(void) {},
> +        AC_LINK_IFELSE(
> +	    [AC_LANG_SOURCE(
> +		[AC_LANG_CASE([C], [[int foo (void) { return 0; }]],
> +			      [C++], [[int foo (void) { return 0; }]],
> +			      [Fortran 77], [[
> +      subroutine foo
> +      end]],
> +			      [Fortran], [[
> +      subroutine foo
> +      end]])])],
>             _LT_TAGVAR(archive_expsym_cmds, $1)='$CC -shared $libobjs $deplibs $compiler_flags ${wl}-soname ${wl}$soname `test -n "$verstring" && func_echo_all "${wl}-set_version ${wl}$verstring"` ${wl}-update_registry ${wl}${output_objdir}/so_locations ${wl}-exports_file ${wl}$export_symbols -o $lib'
>           )
>           LDFLAGS="$save_LDFLAGS"
>
>
>