[PATCH] Fix potential reent issue

Howland Craig D (Craig) howland@LGSInnovations.com
Mon Jun 24 15:04:00 GMT 2013


> From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]
On Behalf Of Federico Terraneo
> Sent: Monday, June 24, 2013 10:51 AM
> To: newlib@sourceware.org
> Subject: Re: [PATCH] Fix potential reent issue
> 
> It wasn't removed, it was just chained to the #if. Now, the 80 char
> per line limit in the email does not help in making the code clear,
but an
> && !defined(__getreent) was added to the #if.
...
> 
> By the way, if you tink this makes the code less clear I can provide a
> patch that nests the #ifndef inside the #if as it was before.
 
No, it is clear enough.  I missed it when reviewing because I used a
different PC than normal and failed to notice a scrollbar to see the
rest
of the line.  Putting it into a different form might make it stand out
more, but I don't think it's worth any effort to do so.



More information about the Newlib mailing list