[PATCH] ARM: Use local labels in strcmp.S

Corinna Vinschen vinschen@redhat.com
Tue Jun 4 08:22:00 GMT 2013


On Jun  4 10:07, Joey Ye wrote:
> strcmp.S defines lots of labels not starting with .L, like
> strcmp_unaligned:
> 
> Comparing to preferred style of starting local labels with .L, these labels
> has two issues:
> 1. Forcing assembler to use 32bit encoding for branches to these labels,
> because of http://sourceware.org/bugzilla/show_bug.cgi?id=12532 . This might
> be a GAS bug as it shouldn't treat them as global symbols if not declared
> with .global.
> 2. Adding unnecessary symbols in symbol table of target object and binary
> 
> This patch fixes it. Size of strcmp is reduced from 584 to 540 for thumb2.
> No performance change observed.
> 
> OK to trunk?

Sure, please apply.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat



More information about the Newlib mailing list