[PATCH 1/3] Change _offset type from int to _off_t

Corinna Vinschen vinschen@redhat.com
Mon Dec 3 13:03:00 GMT 2012

Hi Sebastian,

On Nov 28 14:41, Corinna Vinschen wrote:
> > >That doesn't sound right to me.  As I outlined in my previous reply,
> > >it seems that using int was always wrong and _off_t is the right thing
> > >to do for all targets.
> > [...]
> > >
> > >RTEMS or, FWIW, 64 bit Cygwin (which doesn't exist yet but will have the
> > >same problem) are more or less no-brainers.  My problem, and that's what
> > >I'd like to have input on is, how do we handle backward compatibility
> > >for affected 16 bit or LP64 64 bit targets?
> [...]
> can you please send your patches to fseek/ftell again?  The formatting
> is broken due to the indentation.  Please send the patch as generated by
> `cvs diff -up'.

Thanks for the patches.  I applied them unchanged.

I talked to Jeff via PM and he agreed that, for the sake of correctness,
we have to break backward compatibility for targets with sizeof (int) <
sizeof (long/_off_t).  If that's a really big problem for somebody or
some target, feel free to send a patch to define _off_t as int for your


Corinna Vinschen
Cygwin Project Co-Leader
Red Hat

More information about the Newlib mailing list