[PATCH 1/3] Change _offset type from int to _off_t

[Corinna Vinschen]

Hi Sebastion,

On Nov 26 17:41, Sebastian Huber wrote:
> On 11/26/2012 05:30 PM, Corinna Vinschen wrote:
> >>>> >Any suggestions?
> >>>
> >>>Lets introduce
> >>>
> >>>#if defined(__rtems__) || X
> >>>   typedef _off_t __sFile_off_t;
> >>>#else
> >>>   typedef int __sFile_off_t;
> >>>#endif
> >>>
> >>>somewhere.
> >That doesn't sound right to me.  As I outlined in my previous reply,
> >it seems that using int was always wrong and _off_t is the right thing
> >to do for all targets.
> 
> Yes, I also think that this int is completely wrong, but I cannot
> judge what to do for other targets than RTEMS.  We have a bug vs.
> backward binary compatibility trade off.  For RTEMS it is more
> important to fix the bug.
> 
> >
> >RTEMS or, FWIW, 64 bit Cygwin (which doesn't exist yet but will have the
> >same problem) are more or less no-brainers.  My problem, and that's what
> >I'd like to have input on is, how do we handle backward compatibility
> >for affected 16 bit or LP64 64 bit targets?
> 
> For LP64 targets we can use the __sFile_off_t from above if we want
> to favor backward binary compatibility.  I really have no idea on
> 16-bit targets.  It seems that nobody used FILE at all or only with
> small files on them.

can you please send your patches to fseek/ftell again?  The formatting
is broken due to the indentation.  Please send the patch as generated by
`cvs diff -up'.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat