pthread.h: Add missing PTHREAD_RWLOCK_INITIALIZER

Ralf Corsepius ralf.corsepius@rtems.org
Sat Nov 17 01:01:00 GMT 2012


On 11/12/2012 06:52 PM, Joel Sherrill wrote:
> On 11/12/2012 11:44 AM, Ralf Corsepius wrote:
>> On 11/12/2012 06:19 PM, Joel Sherrill wrote:
>>> Hi
>>>
>>> Attached is a very simple 1 line patch which adds the
>>> missing constant PTHREAD_RWLOCK_INITIALIZER and
>>> makes it have the same value as the other similar
>>> constants.
>>>
>>> OK to commit?
>> No.
> And can you explain why adding an accidentally missing constant
> that is defined by Open Group gets a simple "No"
>
> http://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_rwlock_init.html
>
> This is added in the same style as the other PTHREAD_XXX_INITIALIZER
> values and its absence has just been overlooked.

I realize, I should have been more verbose.

My "no" wasn't directed against adding the initializer #define,
it was directed against the implementation, because I incorrectly
had assumed pthread_rwlock_t to be a pointer.

So, go ahead and apply the patch.

Ralf



More information about the Newlib mailing list