building bug

Jeff Johnston jjohnstn@redhat.com
Tue Aug 9 10:00:00 GMT 2011


On 08/07/2011 08:24 PM, Mike Frysinger wrote:
> On Thursday, August 04, 2011 02:56:17 Mike Stump wrote:
>> -             (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); \
>> +             if (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); then \
>> +               true; \
>> +             else \
>> +               exit 1; \
>> +             fi; \
>
> personally i'd use the oneliner:
>               (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)) || exit $$?; \
> -mike

Actually, the exit 1 is consistent with what autotools are generating
(see newlib/Makefile.in $(RECURSIVE_TARGETS).  I am leaving it as-is to 
be consistent with the subdir_do target.  The newlib generated targets 
also have checks for -k and instead of 'exit 1', set 'fail=yes'.

-- Jeff J.



More information about the Newlib mailing list