[PATCH] CJK ambiguous width for non-Unicode charsets

Corinna Vinschen vinschen@redhat.com
Fri Nov 19 10:03:00 GMT 2010


On Nov 17 21:34, Andy Koppe wrote:
> On 16 November 2010 17:58, Corinna Vinschen wrote:
> > On Nov  9 22:06, Andy Koppe wrote:
> >> The attached small patch affects character widths as reported by
> >> wcwidth(). It addresses an obscure issue.
> >>[...]
> >>       * libc/locale/locale.c: Fix ambigous width to one for singlebyte
> >>       charsets and two for non-Unicode multibyte charsets.
> >
> > This appears to make a lot of sense.  Would you mind to enhance your
> > patch slightly to fix also the description in the locale.c
> > documentation?  There's a related paragraph starting with "This
> > implementation also supports a single modifier, <<"cjknarrow">>..."
> 
> Sorry, I hadn't seen that. Amended patch attached.
> 
> 	* libc/locale/locale.c (loadlocale): Fix width of CJK ambigous
> 	characters to 1 for singlebyte charsets and 2 for non-Unicode
> 	multibyte charsets. Change documentation accordingly.

Thank you.  Applied with a minor change.  @ is a special character
in the docs and has to be doubled ("@@") to be treated literally.
I just removed it entirely since the @ is not part of the modifier
itself.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat



More information about the Newlib mailing list