[PATCH] add <sys/dir.h>

Corinna Vinschen vinschen@redhat.com
Mon Aug 23 15:55:00 GMT 2010


On Aug 11 08:40, Eric Blake wrote:
> On 08/11/2010 08:38 AM, Corinna Vinschen wrote:
> >> <dirent.h> should be providing the C++ guards.  If it is, this instance
> >> in <sys/dir.h> is redundant; if it isn't, then <dirent.h> needs fixing.
> >>
> >> /me goes to check...
> >> Hmm - <dirent.h> _is_ providing C++ guards, but then it includes
> >> <sys/dirent.h> inside guards.  Which means <sys/dirent.h> needs fixing too.
> > 
> > Why?  An application should never include sys/dirent.h directly, right?
> 
> Fair enough for <sys/dirent.h>; but we should still remove the redundant
> guards from <sys/dir.h>.

Agreed.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat



More information about the Newlib mailing list