[PATCH, ARM] Don't use __thumb2__ to select _REENT_SMALL
Richard Earnshaw
rearnsha@arm.com
Tue Jun 2 13:53:00 GMT 2009
This cost me at least a couple of hours debugging at the weekend; I was
trying to work out why my file handles were all corrupted when compiling
code for Thumb-2. It turns out that Newlib's config.h was changing the
ABI depending on the instruction set it was compiling for -- a big No
No, since code is supposed to interwork freely between the two ISAs!
Anyway, I think the following (added by Paul back in 2006) is just
wrong. We need a more precise way to detect M-profile devices if they
must have smaller newlib footprints.
I've chosen to comment out this code rather than remove it, since that
way it acts as a clear reminder as to why we don't want to do this. If
someone adds more precise targeting of M-profile cores, then the code
here can then go entirely.
R.
2009-06-02 Richard Earnshaw <rearnsha@arm.com>
* include/sys/config.h ([__thumb2__]): Don't define _REENT_SMALL.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-patch
Size: 655 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20090602/14225f5d/attachment.bin>
More information about the Newlib
mailing list