[PATCH/RFA] Distinguish between EOF and character with value 0xff

Jeff Johnston jjohnstn@redhat.com
Fri May 1 02:48:00 GMT 2009


Ok to apply.

-- Jeff J.

Eric Blake wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> According to Eric Blake on 4/24/2009 6:41 AM:
>   
>> Would it also be okay to apply this?  The idea is that on cygwin, even
>> though we must call the function to support particular locales, we can
>> still be nice and warn about invalid uses of toupper((char)ch).
>>     
>
> Updated version fixes the regression I added to the return type of toupper
> on single charset platforms, and adds support for the gcc warning under
> multi charset platforms.  I tested that on cygwin, compilation with -O1 is
> identical to the old form.  OK to apply?
>
> 2009-04-29  Eric Blake  <ebb9@byu.net>
>
> 	Allow gcc warning for toupper even with extended charsets.
> 	* libc/include/ctype.h (toupper, tolower)
> 	[_MB_EXTENDED_CHARSETS_ISO]: Allow gcc warning when called with
> 	'char' even when we must call the function for correct behavior.
> 	[!_MB_EXTENDED_CHARSETS_ISO]: Fix regression in result type.
>
> - --
> Don't work too hard, make some time for fun as well!
>
> Eric Blake             ebb9@byu.net
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Cygwin)
> Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkn4SwAACgkQ84KuGfSFAYCDwQCfY2Vc+IapkgIZBWa5SCW0yYaA
> G7MAoJEZkmWXtkeapF7wWV3xLrhxufXn
> =77Fu
> -----END PGP SIGNATURE-----
>   



More information about the Newlib mailing list