PATCH: silence some warnings

Jeff Johnston jjohnstn@redhat.com
Wed Jan 7 22:11:00 GMT 2009


Ok.  Patch checked in.

-- Jeff J.

Ben Elliston wrote:
> This patch silences two warnings in the libgloss build.  First,
> libgloss/doc/Makefile.in was not observing the --datarootdir option.
> Second, the use of $(MULTIDO) in the libgloss top-level Makefile was
> confusing make, so that it did not assume that $(MULTIDO) could ever be
> the make command, issuing the warning:
>
> `warning: jobserver unavailable: using -j1. Add `+' to parent make rule.'
>
> Using `+' should be safe here, because the only other setting for
> $(MULTIDO) is `true', which will ignore any communication from the
> parent make.  This patch fixes these two problems.  Okay for mainline?
>
> Ben
>
>
> 2009-01-06  Ben Elliston  <bje@au.ibm.com>
>
>         * Makefile.in (all): Add `+' to the command line so that the
>         command is always treated as $(MAKE).
>         * doc/Makefile.in (datarootdir): Define.
>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/libgloss/Makefile.in,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile.in
> --- Makefile.in 6 Oct 2006 20:34:49 -0000       1.4
> +++ Makefile.in 6 Jan 2009 04:40:35 -0000
> @@ -94,7 +94,7 @@ FLAGS_TO_PASS = \
>         "DESTDIR=$(DESTDIR)"
>  
>  all: stmp-bsp force
> -       @rootpre=`pwd`/; export rootpre; \
> +       +@rootpre=`pwd`/; export rootpre; \
>         srcrootpre=`cd $(srcdir); pwd`/; export srcrootpre; \
>         $(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=all
>  
> Index: doc/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/libgloss/doc/Makefile.in,v
> retrieving revision 1.2
> diff -u -p -r1.2 Makefile.in
> --- doc/Makefile.in     28 Jun 2004 22:42:19 -0000      1.2
> +++ doc/Makefile.in     6 Jan 2009 04:40:35 -0000
> @@ -17,6 +17,7 @@ VPATH = @srcdir@
>  
>  prefix = @prefix@
>  exec_prefix = @exec_prefix@
> +datarootdir = @datarootdir@
>  
>  mandir = @mandir@
>  man1dir = $(mandir)/man1
>
>
>   



More information about the Newlib mailing list