General cleanup

Jeff Johnston jjohnstn@redhat.com
Fri Dec 12 02:54:00 GMT 2008


Ken Werner wrote:
> On Wednesday 26 November 2008 00:04, Howland Craig D (Craig) wrote:
>   
>> The attached patch does a lot of cleanup (primarily with function
>> prototypes) aimed at reducing the number of compilation warnings.
>> (Using gcc -Wall -Wstrict-prototypes -Wmissing-prototypes, the changes
>> supplied get rid of ~257 warnings.  139 of them were "statement has no
>> effect" warnings, and almost all the rest were prototype related.)  It
>> does not get rid of all of the prototype-related warnings, as I left
>> many
>> that are either of low interest or much work to fix, but I made a really
>> good dent in them.
>> 				Craig
>>     
> Hi Craig,
>
> I noticed you changed the signature of gettimeofday in sys/time.h. According 
> to the Open Group specification the type of the second argument should void* 
> or am I missing something? Here's the URL: 
> http://www.opengroup.org/onlinepubs/009695399/functions/gettimeofday.html
>
> Regards
> Ken
>   
Hi Ken,

Thanks for catching this.  I had forgotten about:

http://sourceware.org/ml/newlib/2007/msg00785.html

I have changed the prototype back and changed the prototype in 
libc/syscalls/sysgettod.c to match.

-- Jeff J.



More information about the Newlib mailing list