[PATCH]: Implement fwide (was Re: swprintf() and friends?)
Wed Dec 10 23:44:00 GMT 2008
On Dec 10 15:40, Jeff Johnston wrote:
> Corinna Vinschen wrote:
>> Did you have a look in the meantime?
> I actually was looking at this today.
> Couple of immediate points:
> 1. In ORIENT, you do a fp->flags != __SORD (should be "|= ")
Ouch! Thanks for spotting.
> 2. ORIENT should not check the value of ori. It is only 0 in one case when
> is used so fwide should check for 0 and not call ORIENT in that case.
Fine with me.
> 3. There doesn't seem to be orientation for the printf family while the
> scanf family is covered
> via vfscanf.
Hmm, you seem to be right. I examined the FreeBSD sources again since I
was pretty sure that the code path will result in calling ORIENT when
calling any printf function. But it really looks like printf doesn't
set the orientation. A bug in the FreeBSD sources? __sfvwrite_r might
be a good point to call ORIENT, right?
> I can fix these myself if you like or you can resubmit if you would like to
I have no problems if you fix that.
Cygwin Project Co-Leader
More information about the Newlib