[Patch] Fix for libgloss configure when LDFLAGS contains whitespace

Christopher Faylor me@cgf.cx
Mon May 12 02:07:00 GMT 2008


On Sun, May 11, 2008 at 01:43:07AM +0300, Marko Lindqvist wrote:
>2008/5/11 Christopher Faylor:
>> On Sat, May 10, 2008 at 11:08:42PM +0300, Marko Lindqvist wrote:
>>  > libgloss configure fails when LDFLAGS contains space. Obvious fix attached.
>>
>>  This can't be right.  That would make all options specified in LDFLAGS
>>  into one argument.
>
> As it should. We are talking about setting environment variable in
>shell script. Can't have several values in one variable :-)
>
> It makes generated shell script config.status to contain
> LDFLAGS="foo bar"
> instead of
> LDFLAGS=foo bar
>
>
> > testvar=foo bar
>bash: bar: command not found

Ah, sorry.  I missed that it was a shell script but your test case is
flawed.

But, btw:

LDFLAGS='a b'
LDFLAGS=${LDFLAGS}

works.

Apparently there is another level of indirection going on which requires
the quotes but it isn't as simple as just saying

ABC=foo bar

on the command line.

cgf



More information about the Newlib mailing list