[PATCH] Fix the spu specific strxfrm to match generic newlib and glibc

Jeff Johnston jjohnstn@redhat.com
Mon Apr 9 17:35:00 GMT 2007


Patrick Mansfield wrote:
> On Fri, Apr 06, 2007 at 10:55:06AM -0500, Joel Schopp wrote:
>> This bug was originally caused by me and my misreading of the standard (to 
>> be fair the language is as clear as mud).  This patch makes the behavior 
>> match what the standard intended, which is also the behavior of glibc.  For 
>> correctness that should probably be my name in the changelog as I 
>> originally authored this patch.
> 
> OK. Jeff can you fix the attribution in the ChangeLog and apply?
> 

Done and done.

-- Jeff J.

> Thanks ...
> 
> -- Patrick Mansfield
> 
>> -Joel
>>
>> Patrick Mansfield wrote:
>>> Jeff - can you please apply this fix?
>>>
>>> Fix the spu specific strxfrm so that when the length of the src string is
>>> greater than or equal to the passed in argument n we still copy over n
>>> bytes.
>>>
>>> This matches the current glibc and the generic newlib strxfrm behaviour.
>>>
>>> newlib ChangeLog:
>>>
>>> 2007-04-06  Patrick Mansfield <patmans@us.ibm.com>
>>>  
>>> 	* libc/machine/spu/strxfrm.c: Fix strxfrm so we still copy data
>>> 	even if the passed in length n is shorter than the source string.
>>> 	This matches both the non-spu specific and the glibc strxfrm
>>> 	behaviour.



More information about the Newlib mailing list