P.S: missing: NEWLIB_VERSION

Jeff Johnston jjohnstn@redhat.com
Tue May 9 19:21:00 GMT 2006


Looks good and works for x86-linux.  Any reason not to check this in?

-- Jeff J.

Joern RENNECKE wrote:
> I am currently testing the attached patch.
> 
> 
> ------------------------------------------------------------------------
> 
> 2006-05-04  J"orn Rennecke <joern.rennecke@st.com>
> 
> 	* acinclude.m4 (_NEWLIB_VERSION): Rename to:
> 	(DEF_NEWLIB_VERSION).
> 	* configure.in (_NEWLIB_VERSION): Use NEWLIB_VERSION.
> 	* configure: Regenerate.
> 
> Index: acinclude.m4
> ===================================================================
> RCS file: /cvs/src/src/newlib/acinclude.m4,v
> retrieving revision 1.24
> diff -p -r1.24 acinclude.m4
> *** acinclude.m4	13 Apr 2006 19:56:22 -0000	1.24
> --- acinclude.m4	4 May 2006 18:35:41 -0000
> ***************
> *** 1,7 ****
>   dnl This provides configure definitions used by all the newlib
>   dnl configure.in files.
>   
> ! AC_DEFUN([_NEWLIB_VERSION],
>   m4_define([NEWLIB_VERSION],[1.14.0]))
>   
>   dnl Basic newlib configury.  This calls basic introductory stuff,
> --- 1,7 ----
>   dnl This provides configure definitions used by all the newlib
>   dnl configure.in files.
>   
> ! AC_DEFUN([DEF_NEWLIB_VERSION],
>   m4_define([NEWLIB_VERSION],[1.14.0]))
>   
>   dnl Basic newlib configury.  This calls basic introductory stuff,
> *************** dnl configure.host.  The only argument i
> *** 10,16 ****
>   dnl newlib directory.
>   
>   AC_DEFUN([NEWLIB_CONFIGURE],
> ! [AC_REQUIRE([_NEWLIB_VERSION])
>   dnl Default to --enable-multilib
>   AC_ARG_ENABLE(multilib,
>   [  --enable-multilib         build many library versions (default)],
> --- 10,16 ----
>   dnl newlib directory.
>   
>   AC_DEFUN([NEWLIB_CONFIGURE],
> ! [AC_REQUIRE([DEF_NEWLIB_VERSION])
>   dnl Default to --enable-multilib
>   AC_ARG_ENABLE(multilib,
>   [  --enable-multilib         build many library versions (default)],
> Index: configure.in
> ===================================================================
> RCS file: /cvs/src/src/newlib/configure.in,v
> retrieving revision 1.32
> diff -p -r1.32 configure.in
> *** configure.in	13 Apr 2006 19:56:23 -0000	1.32
> --- configure.in	4 May 2006 18:35:41 -0000
> *************** if test "${newlib_iconv_external_ccs}" =
> *** 243,249 ****
>   AC_DEFINE_UNQUOTED(_ICONV_ENABLE_EXTERNAL_CCS)
>   fi
>   
> ! AC_DEFINE_UNQUOTED(_NEWLIB_VERSION,"$VERSION")
>   
>   if test "${multilib}" = "yes"; then
>     multilib_arg="--enable-multilib"
> --- 243,249 ----
>   AC_DEFINE_UNQUOTED(_ICONV_ENABLE_EXTERNAL_CCS)
>   fi
>   
> ! AC_DEFINE_UNQUOTED(_NEWLIB_VERSION,"NEWLIB_VERSION")
>   
>   if test "${multilib}" = "yes"; then
>     multilib_arg="--enable-multilib"
> Index: configure
> ===================================================================
> RCS file: /cvs/src/src/newlib/configure,v
> retrieving revision 1.48
> diff -p -r1.48 configure
> *** configure	13 Apr 2006 19:56:22 -0000	1.48
> --- configure	4 May 2006 18:35:43 -0000
> *************** _ACEOF
> *** 5148,5154 ****
>   fi
>   
>   cat >>confdefs.h <<_ACEOF
> ! #define  "$VERSION"
>   _ACEOF
>   
>   
> --- 5148,5154 ----
>   fi
>   
>   cat >>confdefs.h <<_ACEOF
> ! #define _NEWLIB_VERSION "1.14.0"
>   _ACEOF
>   
>   



More information about the Newlib mailing list