sys/signal.h patches breaks bootstrapping gcc

Jeff Johnston jjohnstn@redhat.com
Fri Oct 29 00:49:00 GMT 2004


Ralf,

   Does Chris' patch fix your problem?  If not, I will definitely back it out.

-- Jeff J.

Ralf Corsepius wrote:
> Jeff,
> 
> This patch of yours breaks building gcc/newlib for rtems:
> 
> Index: signal.h
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/include/sys/signal.h,v
> retrieving revision 1.15
> retrieving revision 1.16
> diff -u -r1.15 -r1.16
> --- signal.h    8 Jan 2004 19:25:21 -0000       1.15
> +++ signal.h    8 Oct 2004 17:40:57 -0000       1.16
> @@ -3,6 +3,12 @@
>  #ifndef _SYS_SIGNAL_H
>  #define _SYS_SIGNAL_H
>   
> +#ifndef _SIGNAL_H_
> +/* Some applications take advantage of the fact that <sys/signal.h>
> + * and <signal.h> are equivalent in glibc.  Allow for that here.  */
> +#include <signal.h>
> +#endif
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> 
> The breakdown:
> 
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/build/gcc/xgcc -B/users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/build/gcc/ -nostdinc -B/users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/build/h8300-rtems4.7/h8300h/newlib/ -isystem /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/build/h8300-rtems4.7/h8300h/newlib/targ-include -isystem /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/gcc-3.4.3/newlib/libc/include -B/opt/rtems-4.7/h8300-rtems4.7/bin/ -B/opt/rtems-4.7/h8300-rtems4.7/lib/ -isystem /opt/rtems-4.7/h8300-rtems4.7/include -isystem /opt/rtems-4.7/h8300-rtems4.7/sys-include  -mh -DPACKAGE=\"newlib\" -DVERSION=\"1.12.0\"  -I. -I../../../../../../gcc-3.4.3/newlib/libc/search  -O2 -DHAVE_GETTIMEOFDAY -DMALLOC_PROVIDED -DEXIT_PROVIDED -DMISSING_SYSCALL_NAMES -DSIGNAL_PROVIDED -DREENTRANT_SYSCA
LLS_PROVIDED -DHAVE_OPENDIR -DNO_EXEC -DHAVE_FCNTL -fno-builtin    -O2 -g -O2  -O2 -g -O2 -c ../../../../../../gcc-3.4.3/newlib/libc/search/hash.c
> In file included from
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/gcc-3.4.3/newlib/libc/include/sys/signal.h:9,
>                  from
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/build/h8300-rtems4.7/h8300h/newlib/targ-include/sys/param.h:107,
>                  from
> ../../../../../../gcc-3.4.3/newlib/libc/search/hash.c:37:
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/gcc-3.4.3/newlib/libc/include/signal.h:17: error: syntax error before "_signal_r"
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/gcc-3.4.3/newlib/libc/include/signal.h:17: error: syntax error before "_sig_func_ptr"
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/gcc-3.4.3/newlib/libc/include/signal.h:21: error: syntax error before "signal"
> /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc3.4.3newlib1.12.0/gcc-3.4.3/newlib/libc/include/signal.h:21: error: syntax error before "_sig_func_ptr"
> 
> I'd propose to revert this patch.
> 
> Ralf
> 
> 



More information about the Newlib mailing list