[PATCH]: add missing lock_acquire/release in __fp_lock_all/__fp_unlock_all

Jeff Johnston jjohnstn@redhat.com
Tue Mar 30 07:55:00 GMT 2004


Thomas Pfaff wrote:
> Thomas Pfaff wrote:
> 
>> This locks have been unfortunately removed by me.
>>
>> 2003-03-26  Thomas Pfaff  <tpfaff@gmx.net>
> 
>   2004-03-26

I did see this, but I kind of prefer it this way.  The name of the functions 
imply locking all the files so I'm not sure I like the file-list lock being left 
locked under the covers.  The calls to _fwalk will use the __sfp_lock.

There are also no newlib callers of this function and any Cygwin or newlib code 
could make the calls themselves as needed.  What specific usage do you see for 
this function that the file-list lock is also required?

-- Jeff J.



More information about the Newlib mailing list