[PATCH] libc/sys/cygwin and some Cygwin specifc tweaks
Tue May 13 09:28:00 GMT 2003
Ralf Corsepius wrote:
> Am Mon, 2003-05-12 um 17.32 schrieb Corinna Vinschen:
>>On Mon, May 12, 2003 at 08:07:27AM -0700, Doug Evans wrote:
>>>One might assume that since you work at redhat and that you're
>>>posting to a redhat run list replies will somehow make their
>>>way back to you, but in general people don't know (and shouldn't
>>>be expected to have to check) if you are a member of the list.
>>Sure, but explicitly setting the Reply-To should give a hint ;-)
>>> > What about HAVE_INTERNAL_STAT64 or USE_INTERNAL_STAT64 or something
>>> > like that? We would set this variable in our own cygwin/config.h
>>> > which is loaded through sys/config.h.
>>>Much better (IMO). Thanks.
>>Which one should I use? Jeff?
> IMO, it depends on what these headers are going to be used to.
> If these headers are exported from the source-tree, HAVE_* would
> potentially clash with autoconf's HAVE_* defines generated by
> application configure scripts.
> If these defines are newlib/winsup local, the naming actually doesn't
> matter, except that they should be consistent.
> If these defines are public and the corresponding files using them are
> being exported from the source tree, they IMHO, should be namespaced.
> (Say, ie. __NEWLIB_HAVE_*).
> Just my 0.02 cents.
It should be a double-underscore name. We haven't been prefixing
any of our other configuration variables with __NEWLIB so I would suggest:
-- Jeff J.
More information about the Newlib