[PATCH] libc/sys/cygwin and some Cygwin specifc tweaks

[Corinna Vinschen]

[Please use the list address from my reply-to.  I don't want to get
 private email about public issues.  Thanks for considering.]

On Mon, May 12, 2003 at 07:24:49AM -0700, Doug Evans wrote:
> Corinna Vinschen writes:
>  >         * libc/locale/ldpart.c (__part_load_locale): Use 64 bit stat call
>  >         if __CYGWIN_USE_BIG_TYPES__ is set.
> 
> Note on style: IMO it shouldn't be done this way.
> "cygwin" shouldn't appear in non-cygwin directories.
> The way to do this is define a generic "have feature x" macro,
> use that in the generic directories, and have cygwin define that macro.
> 
> i.e. throughout your patch replace __CYGWIN_USE_BIG_TYPES__
> with something more generic and then have the cygwin port define that
> macro.  I hesitate to suggest __USE_BIG_TYPES__ because that seems
> a bit ambiguous (big types for what?).

What about HAVE_INTERNAL_STAT64 or USE_INTERNAL_STAT64 or something
like that?  We would set this variable in our own cygwin/config.h
which is loaded through sys/config.h.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com