fixed some warnings .....
Manik Raina
manik@cisco.com
Mon Feb 4 23:52:00 GMT 2002
Can someone tell me if these changes are ok ?
can someone commit these ?
Manik Raina wrote:
> fixed some warnings in newlib.
>
> diffs attached... synopsis of fixes
>
> 1. dprint.c
> ===========
>
> parse_number() is defined but not used
>
> 2. dtoa.c
> =========
>
> mlo may be uninitialised in this function
>
> 3. ldtoa.c
> ==========
> unused variables s, p, k, outstr
>
> Index: misc/dprintf.c
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/misc/dprintf.c,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 dprintf.c
> --- dprintf.c 2000/02/17 19:39:47 1.1.1.1
> +++ dprintf.c 2002/02/03 09:53:55
> @@ -15,7 +15,10 @@
> #include "varargs.h"
> #endif
>
> +#ifdef FOR_LATER
> static char *parse_number ();
> +#endif
> +
> static long get_number ();
> static void print_number ();
> static void write_char ();
> @@ -147,6 +150,8 @@
> va_end (args);
> }
>
> +#ifdef FOR_LATER
> +
> /* Parse a positive decimal integer at S.
> FIXME: Was used in earlier version, but not currently used.
> Keep for now. */
> @@ -167,6 +172,8 @@
> *p = x;
> return s;
> }
> +
> +#endif /* FOR_LATER */
>
> /* Fetch the number at S of SIZE bytes. */
>
> Index: stdlib/dtoa.c
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/stdlib/dtoa.c,v
> retrieving revision 1.2
> diff -u -r1.2 dtoa.c
> --- dtoa.c 2000/04/17 17:10:17 1.2
> +++ dtoa.c 2002/02/03 09:53:55
> @@ -229,7 +229,7 @@
> int denorm;
> __ULong x;
> #endif
> - _Bigint *b, *b1, *delta, *mlo, *mhi, *S;
> + _Bigint *b, *b1, *delta, *mlo = NULL, *mhi, *S;
> double ds;
> char *s, *s0;
>
> Index: stdlib/ldtoa.c
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/stdlib/ldtoa.c,v
> retrieving revision 1.3
> diff -u -r1.3 ldtoa.c
> --- ldtoa.c 2000/12/14 00:25:06 1.3
> +++ ldtoa.c 2002/02/03 09:53:56
> @@ -2836,11 +2836,8 @@
> _ldcheck (long double *d)
> {
> unsigned short e[NI];
> -char *s, *p;
> -int k;
> LDPARMS rnd;
> LDPARMS *ldp = &rnd;
> -char *outstr;
>
> rnd.rlast = -1;
> rnd.rndprc = NBITS;
>
> --
> $ /bin/laden
> bash: /bin/laden: No such file or directory
>
> ------------------------------------------------------------------------
> Name: a
> a Type: Plain Text (TEXT/PLAIN)
> Encoding: BASE64
--
- Manik
More information about the Newlib
mailing list