1.3.3-2: fseek fails on multiples of 1024 (binary mode)

Christopher Faylor cgf@redhat.com
Wed Oct 24 08:10:00 GMT 2001

On Wed, Oct 24, 2001 at 05:06:38PM +0200, Pavel Tsekov wrote:
>Christopher Faylor wrote:
>> On Wed, Oct 24, 2001 at 12:37:48PM +0200, Pavel Tsekov wrote:
>> >Again the question is does this optimization actually do something which
>> >is worth to have it in the source three ?  :)
>> IMO, it makes sense for the sources to be as close to the original
>> version as possible.  So, if the optimization exists in FreeBSD, I think
>> it should remain in newlib.  It just makes things easier to decipher the
>> next time we have to compare the two.
>:) It'd be good to put the comment from the FreeBSD CVS so one can know
>in which case the optimisation work (does not work).

Yes.  That would actually bring the sources back into alignment.

Do you want to submit a comprehensive patch to do this?

I noticed that there are more changes to this file, also.  I wasn't sure
if they were new functionality which would require changes elsewhere or
if they were actually bug fixes.

For now, though, adding the necessary lines and comments to fix this
particular problem should be sufficient.  IMO.


More information about the Newlib mailing list