[newlib-cygwin/main] ORIENT: avoid "expression has no effect" warning

Corinna Vinschen corinna@sourceware.org
Fri Jan 19 10:52:10 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=29ec33360da9171f1df27ef59ea4576fda4065ff

commit 29ec33360da9171f1df27ef59ea4576fda4065ff
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Fri Jan 19 11:20:17 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Fri Jan 19 11:51:01 2024 +0100

    ORIENT: avoid "expression has no effect" warning
    
    The warning "right-hand operand of comma expression has no effect
    [-Wunused-value]" crops up with -Wall in cases where ORIENT is called
    without checking or assigning its value.
    
    Explicitely void the expression in these cases to avoid the warning.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/stdio/fwide.c          | 2 +-
 newlib/libc/stdio/open_memstream.c | 2 +-
 newlib/libc/stdio/ungetwc.c        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/newlib/libc/stdio/fwide.c b/newlib/libc/stdio/fwide.c
index 9b5a3d12a793..1d2430468116 100644
--- a/newlib/libc/stdio/fwide.c
+++ b/newlib/libc/stdio/fwide.c
@@ -58,7 +58,7 @@ _fwide_r (struct _reent *ptr,
 
   _newlib_flockfile_start (fp);
   if (mode != 0) {
-    ORIENT (fp, mode);
+    (void) ORIENT (fp, mode);
   }
   if (!(fp->_flags & __SORD))
     ret = 0;
diff --git a/newlib/libc/stdio/open_memstream.c b/newlib/libc/stdio/open_memstream.c
index e3a52ed33dbe..97b13b7bfc10 100644
--- a/newlib/libc/stdio/open_memstream.c
+++ b/newlib/libc/stdio/open_memstream.c
@@ -367,7 +367,7 @@ internal_open_memstream_r (struct _reent *ptr,
   fp->_flags |= __SL64;
 #endif
   fp->_close = memcloser;
-  ORIENT (fp, wide);
+  (void) ORIENT (fp, wide);
   _newlib_flockfile_end (fp);
   return fp;
 }
diff --git a/newlib/libc/stdio/ungetwc.c b/newlib/libc/stdio/ungetwc.c
index 16d37f2d176c..a04ca3467d61 100644
--- a/newlib/libc/stdio/ungetwc.c
+++ b/newlib/libc/stdio/ungetwc.c
@@ -82,7 +82,7 @@ _ungetwc_r (struct _reent *ptr,
   size_t len;
 
   _newlib_flockfile_start (fp);
-  ORIENT (fp, 1);
+  (void) ORIENT (fp, 1);
   if (wc == WEOF)
     wc = WEOF;
   else if ((len = _wcrtomb_r(ptr, buf, wc, &fp->_mbstate)) == (size_t)-1)


More information about the Newlib-cvs mailing list