[newlib-cygwin] Drop redundant checks for NULL input string in wctomb helper funcs

Corinna Vinschen corinna@sourceware.org
Sat Oct 22 19:10:00 GMT 2016


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5005be3daf756a6a6dd4043ac9352e1c4b4af202

commit 5005be3daf756a6a6dd4043ac9352e1c4b4af202
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Sat Oct 22 20:28:08 2016 +0200

    Drop redundant checks for NULL input string in wctomb helper funcs
    
    Fixes Coverity CIDs 153465 and 153466
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/stdlib/wctomb_r.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/newlib/libc/stdlib/wctomb_r.c b/newlib/libc/stdlib/wctomb_r.c
index 02b85e6..2c018f9 100644
--- a/newlib/libc/stdlib/wctomb_r.c
+++ b/newlib/libc/stdlib/wctomb_r.c
@@ -284,9 +284,6 @@ ___iso_wctomb (struct _reent *r, char *s, wchar_t _wchar, int iso_idx,
 	{
 	  unsigned char mb;
 
-	  if (s == NULL)
-	    return 0;
-
 	  for (mb = 0; mb < 0x60; ++mb)
 	    if (__iso_8859_conv[iso_idx][mb] == wchar)
 	      {
@@ -443,9 +440,6 @@ ___cp_wctomb (struct _reent *r, char *s, wchar_t _wchar, int cp_idx,
 	{
 	  unsigned char mb;
 
-	  if (s == NULL)
-	    return 0;
-
 	  for (mb = 0; mb < 0x80; ++mb)
 	    if (__cp_conv[cp_idx][mb] == wchar)
 	      {



More information about the Newlib-cvs mailing list