[PATCH] Fix xmlout option
Omair Majid
omajid@redhat.com
Fri Feb 13 15:08:00 GMT 2009
Hi Mark,
Mark Wielaard wrote:
> Thanks. It took me some time to understand how this was supposed to work
> with the ping-pong between Harness and RunnerProcess. I am afraid you
> might be the first one in a long time that has worked with the xml
> output. So don't be surprised if you find more bugs. Sorry about that.
I am just glad there is an xmlout option at all!
> I think you should explicitly check that args.length still has another
> element like the other checks before this one. The help message implies
> that the file name is optional, but it really isn't since RunnerProcess
> depends on it. Could you make that change and update the help message?
Good catch. Fixed patch attached. I am not sure how the help message
indicates that the file name is optional. 'filename' in '-file
[filename]' is required and so is 'millis' in '-timeout [millis]'.
Cheers,
Omair
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: harness-option-xmlout.patch
URL: <http://sourceware.org/pipermail/mauve-patches/attachments/20090213/0fb1b62a/attachment.ksh>
More information about the Mauve-patches
mailing list