[PATCH] libstdc++: Updated inplace_vector::try_ functions per P3981R2 and P4022R0.
Jonathan Wakely
jwakely@redhat.com
Thu Apr 2 13:02:31 GMT 2026
On Thu, 2 Apr 2026 at 13:30, Nathan Myers <ncm@cantrip.org> wrote:
>
> LGTM.
>
> About testsuite/23_containers/inplace_vector/version.cc ...
> Should I have counterparts to this test for other feature
> macros I add or alter?
Those version.cc tests made more sense when we defined the feature
test macros manually, which was error prone and needed more careful
testing.
Now that they're autogenerated from version.def testing them is less
important. If the code is gated on the macro, and the test verifies
that the code works in a given -std mode, then the macro is probably
correct.
In theory the test could catch a typo in the value of the macro, but
in practice we probably copy&paste the value from the version.def file
into the test anyway.
More information about the Libstdc++
mailing list