[committed] libstdc++: Fix three-way comparison for std::array [PR 96851]

Jonathan Wakely jwakely@redhat.com
Wed Sep 2 15:44:56 GMT 2020


On 02/09/20 15:51 +0100, Jonathan Wakely wrote:
>The spaceship operator for std::array uses memcmp when the
>__is_byte<value_type> trait is true, but memcmp isn't usable in
>constexpr contexts. Also, memcmp should only be used for unsigned byte
>types, because it gives the wrong answer for signed chars with negative
>values.
>
>We can simply check std::is_constant_evaluated() so that we don't use
>memcmp during constant evaluation.
>
>To fix the problem of using memcmp for inappropriate types, this patch
>adds new __is_memcmp_ordered and __is_memcmp_ordered_with traits. These
>say whether using memcmp will give the right answer for ordering
>operations such as lexicographical_compare and three-way comparisons.
>The new traits can be used in several places, and can also be used to
>implement my suggestion in PR 93059 comment 37 to use memcmp for
>unsigned integers larger than one byte on big endian targets.
>
>libstdc++-v3/ChangeLog:
>
>	PR libstdc++/96851
>	* include/bits/cpp_type_traits.h (__is_memcmp_ordered):
>	New trait that says if memcmp can be used for ordering.
>	(__is_memcmp_ordered_with): Likewise, for two types.
>	* include/bits/deque.tcc (__lex_cmp_dit): Use new traits
>	instead of __is_byte and __numeric_traits.
>	(__lexicographical_compare_aux1): Likewise.
>	* include/bits/ranges_algo.h (__lexicographical_compare_fn):
>	Likewise.
>	* include/bits/stl_algobase.h (__lexicographical_compare_aux1)
>	(__is_byte_iter): Likewise.
>	* include/std/array (operator<=>): Likewise. Only use memcmp
>	when std::is_constant_evaluated() is false.
>	* testsuite/23_containers/array/comparison_operators/96851.cc:
>	New test.
>	* testsuite/23_containers/array/tuple_interface/get_neg.cc:
>	Adjust dg-error line numbers.

For the gcc-10 branch I've committed the attached backport, which adds
the new traits and uses them everywhere appropriate, but doesn't
extend the memcmp optimisation to all unsigned integers for big endian
targets.

Tested x86_64-linux. Committed to gcc-10.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 11834 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/libstdc++/attachments/20200902/ead44be5/attachment.bin>


More information about the Libstdc++ mailing list