[PATCH] libstdc++: Fix capturing of lvalue references in_RangeAdaptor::operator()

Jonathan Wakely jwakely@redhat.com
Thu Feb 20 18:39:00 GMT 2020


On 20/02/20 12:19 -0500, Patrick Palka wrote:
>This fixes a dangling-reference issue with views::split and other multi-argument
>adaptors that may take its extra arguments by reference.
>
>When creating the _RangeAdaptorClosure in _RangeAdaptor::operator(), we
>currently capture all provided arguments by value.  When we later use the
>_RangeAdaptorClosure and call it with a range, as in e.g.
>
>    v = views::split(p)(range),
>
>we forward the range and the captures to the underlying adaptor routine.  But
>then when the temporary _RangeAdaptorClosure goes out of scope, the by-value
>captures get destroyed and the references to these capture in the resulting view
>become dangling.
>
>This patch fixes this problem by capturing lvalue references by reference in
>_RangeAdaptorClosure::operator(), and then forwarding the captures appropriately
>to the underlying range adaptor.

OK for master. Thanks for figuring this one out.




More information about the Libstdc++ mailing list