[PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors

Jonathan Wakely jwakely@redhat.com
Fri Sep 27 16:21:00 GMT 2019


On 27/09/19 18:07 +0200, François Dumont wrote:
>On 9/26/19 3:20 PM, Jonathan Wakely wrote:
>>Fix data race when _Safe_iterator_base::_M_detach() runs 
>>concurrently with
>>the _Safe_container_base destructor.
>>
>>    PR libstdc++/91910
>>    * src/c++11/debug.cc (_Safe_iterator_base::_M_detach()): Load pointer
>>    atomically and lock the mutex before accessing the sequence.
>>    (_Safe_iterator_base::_M_reset()): Clear _M_sequence atomically.
>>
>>Tested x86_64-linux. I plan to commit this to trunk unless somebody
>>sees a problem with it.
>>
>>
>Thanks to the additional _M_sequence check in _M_detach_single() this 
>patch looks good.

Thanks, it's now committed to trunk.

We might want to backport this. I'll leave it on trunk for a while
first though.




More information about the Libstdc++ mailing list