[PATCH] PR libstdc++/70940 optimize pmr::resource_adaptor for allocators using malloc

Jonathan Wakely jwakely@redhat.com
Thu Jul 26 11:19:00 GMT 2018


On 26/07/18 13:11 +0200, Rainer Orth wrote:
>Hi Jonathan,
>
>> Rainer, this is another place where alignof(max_align_t) gets encoded
>> into the ABI, so is affected by PR 77691 as well.
>
>indeed, fixed by the following patch.  Tested on i386-pc-solaris2.11,
>ok for mainline?

OK, thanks.

>The ugly thing about xfailing the affected tests is that they will XPASS
>once in a while when malloc happens to return 16-byte aligned memory.
>However, I'm reluctant to skip them instead at least while there's a
>chance that Solaris will fix 32-bit x86 malloc alignment post Solaris
>11.4.

Yes, it isn't ideal to have them flip between XFAIL and XPASS, but I
agree that simply skipping them is worse.




More information about the Libstdc++ mailing list