[PATCH 1/2] condition_variable: Report early wakeup of wait_until as no_timeout
François Dumont
frs.dumont@gmail.com
Tue Jul 24 19:44:00 GMT 2018
On 24/07/2018 13:57, Jonathan Wakely wrote:
> On 24/07/18 12:04 +0200, François Dumont wrote:
>>
>> This patch claims that it just replaces a cv_status::timeout into
>> cv_status::no_timeout if we didn't wait enough. But it also replaces
>> any cv_status returned by __wait_until_impl into a
>> cv_status::no_timeout, is that intentional ? IMHO it should store the
>> returned status and return it unchanged if not timeout.
>
> But __wait_until_impl can only return timeout or no_timeout:
>
> enum class cv_status { no_timeout, timeout };
>
I didn't want to check __wait_until_impl cause my remark was more general.
But if enum only has 2 entries it sounds safe enough indeed.
More information about the Libstdc++
mailing list