[v3 PATCH] Make optional conditionally trivially_{copy,move}_{constructible,assignable}

[Jonathan Wakely]

On 14/01/18 01:09 +0200, Ville Voutilainen wrote:
>On 8 January 2018 at 15:36, Jonathan Wakely <jwakely@redhat.com> wrote:
>> On 25/12/17 23:59 +0200, Ville Voutilainen wrote:
>>>
>>> In the midst of the holiday season, the king and ruler of all elves,
>>> otherwise
>>> known as The Elf, was told by little elves that users are complaining how
>>> stlstl and libc++ make optional's copy and move operations conditionally
>>> trivial, but libstdc++ doesn't. This made The Elf fairly angry, and he
>>> spoke
>>> "this will not stand".
>>>
>>> Tested on Linux-PPC64. The change is an ABI break due to changing
>>> optional<triviallycopyable> to a trivially copyable type. It's perhaps
>>> better to get that ABI break in now rather than later.
>>
>>
>> Agreed, but a few comments and questions below.
>
>New patch attached. I made _M_reset and _M_destruct noexcept, and
>added a comment about the protected
>inheritance in the code. Please double-check the whitespace department.

Thanks, OK for trunk.