[PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)
Jason Merrill
jason@redhat.com
Tue Oct 24 20:26:00 GMT 2017
On Tue, Oct 24, 2017 at 3:36 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Oct 24, 2017 at 01:55:58PM -0400, Jason Merrill wrote:
>> On Tue, Oct 24, 2017 at 11:33 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> > On Tue, Oct 24, 2017 at 11:06:51AM -0400, Jason Merrill wrote:
>> >> On 09/29/2017 08:32 AM, Jakub Jelinek wrote:
>> >> > + tree b = builtin_decl_explicit (DECL_FUNCTION_CODE (newdecl));
>> >> > + if (b)
>> >> > + duplicate_one_attribute (&DECL_ATTRIBUTES (b),
>> >> > + DECL_ATTRIBUTES (newdecl),
>> >> > + "omp declare simd");
>> >>
>> >> It occurs to me that we're likely to want to propagate other attributes to
>> >> the builtin, too. In the testcase, nothrow and leaf also seem appropriate.
>> >> Do we want a broader copy_attributes_to_builtin function, even if it only
>> >> copies this omp attribute for now?
>> >
>> > So like this?
>>
>> I was thinking that the new function would decide which attributes we
>> want to copy over, rather than have a "name" parameter.
>
> Like this then?
Yes, thanks. This patch is OK.
Jason
More information about the Libstdc++
mailing list