What are these "profile" tests for?!

[François Dumont]

Yes, those tests doesn't seem to demonstrate anything.

When run with check-profile it only shows an advise about replacing the 
vector with a list. Maybe it doesn't show more because there has been 
regression but if so it only shows that those tests are not detecting 
such regression.

François

On 23/06/2017 18:49, Jonathan Wakely wrote:
> I've just noticed these three tests which just seems to create very
> large containers:
>
> 23_containers/unordered_map/profile/hash_map.cc
> 23_containers/unordered_map/profile/unordered.cc
> 23_containers/vector/profile/vector.cc
>
> Does anybody know what they're for? They say
>
> // Insert more than default item
>
> They all use the magic number 10000 which occurs in
> <profile/impl/profiler_trace.h> so I assume they're trying to test
> what happens when some limit is exceeded, but the tests don't actually
> use profile mode! Should they be using -D_GLIBCXX_PROFILE? Or are they
> only meant to test anything useful when doing "make check-profile"?
>
> Maybe I should hurry up and add SystemTap probe points to the
> containers so we can simply delete profile mode.
>
>