[patch] Some testsuite cleanup

[Jonathan Wakely]

On 01/08/16 09:23 -0700, Mike Stump wrote:
>On Jul 31, 2016, at 1:30 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> -fno-show-column
>
>is a good general option.  If you guys want to add column number test cases, they can avoid it, and test down to the column.  Most people don't care, and most test aren't interested in column testing anyway.  But, if you want to do a sea change, you can add column numbers to every expected line and that way, they all will fail, if any of the numbers go wrong.  If someone wants to sign up for that, it is slightly better, but requires that someone do all the work.

OK, thanks Mike.

I plan to make this change then (rather than adding it to individual
tests as and when we find one that needs it).

--- a/libstdc++-v3/scripts/testsuite_flags.in
+++ b/libstdc++-v3/scripts/testsuite_flags.in
@@ -56,7 +56,7 @@ case ${query} in
       echo ${CC}
       ;;
     --cxxflags)
-      CXXFLAGS_default="-D_GLIBCXX_ASSERT -fmessage-length=0"
+      CXXFLAGS_default="-D_GLIBCXX_ASSERT -fmessage-length=0 -fno-show-column"
       CXXFLAGS_config="@SECTION_FLAGS@ @EXTRA_CXX_FLAGS@"
       echo ${CXXFLAGS_default} ${CXXFLAGS_config} 
       ;;

This adds it to the default flags used for the entire libstdc++ testsuite.