[PATCH][libstdc++][testsuite] Mark as UNSUPPORTED tests that don't fit into tiny memory model

Kyrill Tkachov kyrylo.tkachov@arm.com
Wed Dec 10 18:05:00 GMT 2014


On 09/12/14 20:14, Mike Stump wrote:
> On Dec 9, 2014, at 3:17 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>> In the gcc and g++ testsuite we already catch such cases and mark them as UNSUPPORTED. In libstdc++.exp there is no such functionality.
>> I'm not very happy that it had to be copied, but I couldn't find a way to include the gcc definition sanely.
>> Is this a sane approach to what I'm trying to solve?
> Ok.
>
> If you would like, you can try and pull the common parts out into a new file, and include (load) that file from the two places that currently do that.  If they are exactly identical, should be trivial enough.  If not exactly the same, I’d do two patches, once to make them the same, then, the second one to split them out.

Thanks for the guidance. I've moved the definitions into a separate file 
and included that in the places that use it (more than 2 places in my 
count). This is the patch attached.

The second patch (will send shortly after this) adds the logic to libstdc++.

Ok?

Kyrilll


2014-12-10  Kyrylo Tkachov  kyrylo.tkachov@arm.com

     * lib/target-utils.exp: New file.
     * lib/gcc-defs.exp (${tool}_check_unsupported_p): Delete.
     Include target-utils.exp.
     * lib/objc.exp: Likewise.
     * lib/mike-gcc.exp: Load target-utils.exp.
     * lib/mike-g++.exp: Likewise.
     * lib/go-torture.exp: Likewise.
     * lib/fortran-torture.exp: Likewise.
     * lib/c-torture.exp: Likewise.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: testsuite-check-unsupported.patch
Type: text/x-patch
Size: 7037 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20141210/baa06d07/attachment.bin>


More information about the Libstdc++ mailing list