PR libstdc++/54576: random_device isn't protected by _GLIBCXX_USE_C99_STDINT_TR1

Paolo Carlini paolo.carlini@oracle.com
Fri Sep 14 09:48:00 GMT 2012


Hi,

On 09/14/2012 03:16 AM, H.J. Lu wrote:
> Hi,
>
> include/random has
>
> #ifdef _GLIBCXX_USE_C99_STDINT_TR1
>
> #include <cstdint> // For uint_fast32_t, uint_fast64_t, uint_least32_t
> #include <bits/random.h>
> #include <bits/random.tcc>
>
> #endif // _GLIBCXX_USE_C99_STDINT_TR1
>
> random_device is defined in <bits/random.h>. But src/c++11/random.cc
> has
>
> #include <random>
> ...
>    void
>    random_device::_M_init(const std::string& token)
>    {
>
> It doesn't check if _GLIBCXX_USE_C99_STDINT_TR1 is defined.  This
> patch checks it.  OK to install?
I thought this was already history, because it's a Dup.

Anyway, the obvious patch is Ok, thanks, but please put a blank line 
right after "#ifdef _GLIBCXX_USE_C99_STDINT_TR1"-

Thanks!
Paolo.



More information about the Libstdc++ mailing list