[v3] Handle different versions of Solaris 8 <iso/math_iso.h>, <iso/stdlib_iso.h>

Paolo Carlini pcarlini@gmail.com
Sat Aug 27 10:33:00 GMT 2011


Hi,

> -PASS: abi/header_cxxabi.c (test for excess errors)
> +FAIL: abi/header_cxxabi.c (test for excess errors)
> 
> FAIL: abi/header_cxxabi.c (test for excess errors)
> Excess errors:
> /var/gcc/regression/trunk/11-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/i386-pc-solaris2.11/bits/c++config.h:167:1: error: unknown type name 'namespace'
> /var/gcc/regression/trunk/11-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/i386-pc-solaris2.11/bits/c++config.h:168:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
> 
> which is pretty obvious given that this test is supposed to be compiled
> as C :-)

To be honest, I'm not at all sure to understand what's going on here, maybe we should return to the fail later.

> I guess the patch is ok now?

Yes. Nice that Jon replied in the meanwhile and clarified the undefined behavior issue: for the time being I think we can keep the __cplusplus checks, should also help during this testing period. We can certainly clean up the thing later. Maybe you could add a comment somewhere summarizing what Jon wrote.

By the way I noticed only today (sorry, I'm using a phone ;) that all the new configury work impacts only Solaris configuration, thus in general we are on pretty safe ground

Paolo



More information about the Libstdc++ mailing list